Include empty glyphs when calculating max width, to match fonttools #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most fields in `hhea` are set based on glyphs with bounds: https://github.com/fonttools/fonttools/blob/e04dfaab/Lib/fontTools/ttLib/tables/_h_h_e_a.py#L101-L119 but `advanceWidthMax` is an exception to this, as it considers every glyph that has an entry in the `hmtx` table: https://github.com/fonttools/fonttools/blob/e04dfaab/Lib/fontTools/ttLib/tables/_h_h_e_a.py#L73
|
(forgot to add: the spec confirms that fonttools is doing the right thing here too ⚖️) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most fields in
hheaare set based only on glyphs with bounds, butadvanceWidthMaxis an exception to this, as it considers every glyph that has an entry inhmtx.This commit includes empty glyphs in the calculation of the field, which matches fontmake's behaviour. After this change, Fleur De Leah compiles identically:
Note: this is a personal contribution independent of my employer, and so I've submitted from a fork under my personal profile and email to make this distinction