Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Update richmarker.js to send marker as argument to 'dragend' callback #5

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

tudorpavel
Copy link

Unless the marker object is sent as an argument in the callback, you can only use anonymous functions which have the marker in scope.

google.maps.event.addListener(marker, 'dragend', function() {
  marker.getPosition() // do something with new marker location
});

I see no problem with sending the marker as an argument to the callback, it's what the normal Google Maps markers do. With this simple change we can do something like the following.

function dragendCallback(marker) {
  marker.getPosition() // do something with new marker location
}

// Somewhere else where the marker is created
google.maps.event.addListener(marker, 'dragend', dragendCallback);

Review on Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Unless the marker object is sent as an argument in the callback, you can only use anonymous functions which have the marker in scope.
@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants