Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: validate unmanaged dependency check in a few downstream repositories #2426

Merged
merged 11 commits into from
Jan 28, 2024

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 26, 2024

Fixes #2425

With this validation, we can see whether a change made to UnmanagedDependencyCheck is causing check failure in the downstream repository. When there's a bad change, the check fails with the following message:

With this change, the unmanaged dependencies check installed in java-bigtable will start to fail due to [com.google.api.grpc:grpc-google-cloud-bigtable-admin-v2, com.google.api.grpc:grpc-google-cloud-bigtable-v2, com.google.api.grpc:proto-google-cloud-bigtable-v2, com.google.api.grpc:proto-google-cloud-bigtable-admin-v2], among the artifacts listed in /home/runner/work/sdk-platform-java/sdk-platform-java/java-bigtable/google-cloud-bigtable-bom/pom.xml.

Screenshot 2024-01-26 at 4 32 54 PM

@suztomo suztomo requested a review from a team as a code owner January 26, 2024 20:06
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 26, 2024
@suztomo suztomo changed the title downstream unmanaged dependency check ci: validating unmanaged dependency check in a few downstream repositories Jan 26, 2024
@suztomo suztomo marked this pull request as draft January 26, 2024 20:07
@suztomo suztomo changed the title ci: validating unmanaged dependency check in a few downstream repositories ci: validate unmanaged dependency check in a few downstream repositories Jan 26, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2024
@suztomo suztomo requested a review from JoeWang1127 January 26, 2024 22:12
@suztomo suztomo marked this pull request as ready for review January 28, 2024 01:52
@suztomo suztomo merged commit 0d7303c into main Jan 28, 2024
42 checks passed
@suztomo suztomo deleted the downstream_unmanaged_dependency_check branch January 28, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downstream Check for Unmanaged Dependency Check
2 participants