Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Inheriting <auto-value.version> from java-shared-config instead of gapic-pom-parent #2072

Merged
merged 1 commit into from
Oct 5, 2023
Merged

deps: Inheriting <auto-value.version> from java-shared-config instead of gapic-pom-parent #2072

merged 1 commit into from
Oct 5, 2023

Conversation

ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Oct 5, 2023 •
edited
Loading

This PR bumps java-shared-config to 1.5.8 and removes <auto-value.version> property declaration from the gapic-pom-parent. This version will be inherited from java-shared-config from now on. Current latest version for <auto-value> is 1.10.4.

Resolves RequireUpperBoundDeps error found in #2066.

@ddixit14 ddixit14 requested a review from a team as a code owner October 5, 2023 19:18
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ddixit14
Copy link
Contributor Author

ddixit14 commented Oct 5, 2023

  1. Kokoro - Test: Downstream Java 17 GraalVM Native Image — Build failed
  2. Kokoro - Test: Downstream Java GraalVM Native Image — Build failed

Even though the status reported is "Build failed", the logs show that the build is success.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ddixit14 ddixit14 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
@ddixit14 ddixit14 merged commit fa5e937 into main Oct 5, 2023
37 checks passed
@ddixit14 ddixit14 deleted the java-shared-config-bump branch October 5, 2023 19:50
@release-please release-please bot mentioned this pull request Oct 6, 2023
Merged
@ddixit14 ddixit14 changed the title deps: Bumping java-shared-config to 1.5.8 deps: Inheriting <auto-value.version> from java-shared-config instead of gapic-pom-parent Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddixit14 @suztomo @yoshi-kokoro