Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restore monorepo check to be pinned at latest version #2019

Merged
merged 1 commit into from
Sep 21, 2023
Merged

chore: restore monorepo check to be pinned at latest version #2019

merged 1 commit into from
Sep 21, 2023

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Sep 20, 2023 •
edited
Loading

Follow-up to #1989

The check will temporarily fail until we make a new release of google-cloud-java with googleapis/google-cloud-java#9854 is made.

@mpeddada1 mpeddada1 requested a review from a team as a code owner September 20, 2023 20:37
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 20, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@burkedavison
Copy link
Member

Only test failing is "Downstream Check / downstream-compatibility (google-cloud-java)".

This is expected due to removal of experimental API in gRPC. @mpeddada1 : PR is ready for merge.

@mpeddada1 mpeddada1 merged commit 4d68e44 into main Sep 21, 2023
@mpeddada1 mpeddada1 deleted the pin-repo-downstream-check branch September 21, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpeddada1 @burkedavison