Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump grpc version to 1.58.0 and protobuf to 3.24.0 #1989

Merged
merged 26 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3edbe8c
build(deps): bump grpc version to 1.58.0
mpeddada1 Sep 13, 2023
dda9e62
upudate protobuf to 3.24.0
mpeddada1 Sep 13, 2023
1cb8aa5
remove temporary j2objc exclusion
mpeddada1 Sep 13, 2023
977b725
upgrade errorprone version to 2.20.0
mpeddada1 Sep 14, 2023
347b80e
update errorprone version to 2.20.0 in dependencies.properties for co…
mpeddada1 Sep 14, 2023
a1abf46
update errorprone version in api-common and gapic-generator
mpeddada1 Sep 14, 2023
7b7d626
add gax-inprocess
mpeddada1 Sep 14, 2023
49d7be2
regenerate showcase
mpeddada1 Sep 15, 2023
e33a50f
Merge branch 'main' of github.com:googleapis/sdk-platform-java into g…
mpeddada1 Sep 18, 2023
339391c
Merge branch 'main' of github.com:googleapis/sdk-platform-java into g…
mpeddada1 Sep 18, 2023
1857d25
Merge remote-tracking branch 'origin/main' into grpc-1.58.0
diegomarquezp Sep 18, 2023
f4c0029
regenerate showcase classes
mpeddada1 Sep 18, 2023
66f589f
Merge branch 'grpc-1.58.0' of github.com:googleapis/sdk-platform-java…
mpeddada1 Sep 18, 2023
8017b80
update integration test golden files
mpeddada1 Sep 18, 2023
b8a15f6
test ga run from sha
mpeddada1 Sep 18, 2023
6740d5e
revert change to ga settings
mpeddada1 Sep 19, 2023
309093c
replace tag with latest
mpeddada1 Sep 19, 2023
56b4b77
upgrade tag
mpeddada1 Sep 19, 2023
0f27b20
remove tag
mpeddada1 Sep 19, 2023
322c838
empty commit for builds
mpeddada1 Sep 19, 2023
fcc497f
version with SHA
mpeddada1 Sep 19, 2023
45794d5
use commit with other grpc exclusions
mpeddada1 Sep 19, 2023
646d460
use up-to-date sha
mpeddada1 Sep 19, 2023
b8c7b4d
empty commit for build
mpeddada1 Sep 20, 2023
e693e01
modify script to test against monorepo HEAD
mpeddada1 Sep 20, 2023
af0aa38
remove unused variable assignment
mpeddada1 Sep 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ jobs:
run: |
mvn install -B -ntp -DskipTests -Dclirr.skip -Dcheckstyle.skip
- name: Validate gapic-generator-java-bom
uses: googleapis/java-cloud-bom/tests/validate-bom@v26.13.0
uses: googleapis/java-cloud-bom/tests/validate-bom
mpeddada1 marked this conversation as resolved.
Show resolved Hide resolved
with:
bom-path: gapic-generator-java-bom/pom.xml

Expand Down
2 changes: 1 addition & 1 deletion api-common-java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<dependency>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
<version>2.18.0</version>
<version>2.20.0</version>
<scope>compile</scope>
</dependency>

Expand Down
7 changes: 2 additions & 5 deletions gapic-generator-java-pom-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,12 @@
consistent across modules in this repository -->
<javax.annotation-api.version>1.3.2</javax.annotation-api.version>
<auto-value.version>1.10.2</auto-value.version>
<grpc.version>1.56.1</grpc.version>
<grpc.version>1.58.0</grpc.version>
<google.auth.version>1.19.0</google.auth.version>
<google.http-client.version>1.43.3</google.http-client.version>
<gson.version>2.10.1</gson.version>
<guava.version>32.1.2-jre</guava.version>
<!-- On next protobuf upgrade (to 3.23.3 or higher),
remove temporarily j2objc-annotations exclusions from protobuf-java-util dependencies.
For context: https://github.com/googleapis/sdk-platform-java/pull/1791-->
<protobuf.version>3.23.2</protobuf.version>
<protobuf.version>3.24.0</protobuf.version>
<maven.compiler.release>8</maven.compiler.release>
</properties>

Expand Down
2 changes: 1 addition & 1 deletion gapic-generator-java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@
<dependency>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
<version>2.18.0</version>
<version>2.20.0</version>
</dependency>

<!--
Expand Down
6 changes: 3 additions & 3 deletions gax-java/dependencies.properties
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ version.gax_httpjson=2.33.1-SNAPSHOT
# On next protobuf upgrade (to 3.23.3 or higher),
# remove temporarily j2objc-annotations exclusions from protobuf-java-util dependencies.
# For context: https://github.com/googleapis/sdk-platform-java/pull/1791
version.com_google_protobuf=3.23.2
version.com_google_protobuf=3.24.0
version.google_java_format=1.15.0
version.io_grpc=1.56.1
version.io_grpc=1.58.0

# Maven artifacts.
# Note, the actual name of each property matters (bazel build scripts depend on it).
Expand Down Expand Up @@ -65,7 +65,7 @@ maven.com_google_guava_failureaccess=com.google.guava:failureaccess:1.0.1
maven.org_apache_commons_commons_lang3=org.apache.commons:commons-lang3:3.12.0
maven.com_google_android_annotations=com.google.android:annotations:4.1.1.4
maven.com_google_code_findbugs_jsr305=com.google.code.findbugs:jsr305:3.0.2
maven.com_google_errorprone_error_prone_annotations=com.google.errorprone:error_prone_annotations:2.18.0
maven.com_google_errorprone_error_prone_annotations=com.google.errorprone:error_prone_annotations:2.20.0
maven.com_google_j2objc_j2objc_annotations=com.google.j2objc:j2objc-annotations:2.8
maven.com_google_auto_value_auto_value=com.google.auto.value:auto-value:1.10.2
maven.com_google_auto_value_auto_value_annotations=com.google.auto.value:auto-value-annotations:1.10.2
Expand Down
4 changes: 4 additions & 0 deletions gax-java/gax-grpc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
<groupId>io.grpc</groupId>
<artifactId>grpc-api</artifactId>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-inprocess</artifactId>
</dependency>
<dependency>
<groupId>org.threeten</groupId>
<artifactId>threetenbp</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion java-shared-dependencies/third-party-dependencies/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<animal-sniffer.version>1.23</animal-sniffer.version>
<opencensus.version>0.31.1</opencensus.version>
<findbugs.version>3.0.2</findbugs.version>
<errorprone.version>2.18.0</errorprone.version>
<errorprone.version>2.20.0</errorprone.version>
<jackson.version>2.15.2</jackson.version>
<codec.version>1.15</codec.version>
<httpcomponents.httpcore.version>4.4.16</httpcomponents.httpcore.version>
Expand Down
6 changes: 0 additions & 6 deletions java-shared-dependencies/upper-bound-check/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,6 @@
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java-util</artifactId>
<exclusions>
<exclusion>
<groupId>com.google.j2objc</groupId>
<artifactId>j2objc-annotations</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,78 @@
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FeatureSet",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FeatureSet$Builder",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FeatureSet$EnumType",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FeatureSet$FieldPresence",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FeatureSet$JsonFormat",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FeatureSet$MessageEncoding",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FeatureSet$RepeatedFieldEncoding",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FeatureSet$StringFieldValidation",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FieldDescriptorProto",
"queryAllDeclaredConstructors": true,
Expand Down Expand Up @@ -1142,6 +1214,24 @@
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FieldOptions$EditionDefault",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FieldOptions$EditionDefault$Builder",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.protobuf.DescriptorProtos$FieldOptions$JSType",
"queryAllDeclaredConstructors": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public final class ComplianceGrpc {

private ComplianceGrpc() {}

public static final String SERVICE_NAME = "google.showcase.v1beta1.Compliance";
public static final java.lang.String SERVICE_NAME = "google.showcase.v1beta1.Compliance";

// Static method descriptors that strictly reflect the proto.
private static volatile io.grpc.MethodDescriptor<com.google.showcase.v1beta1.RepeatRequest,
Expand Down Expand Up @@ -1124,9 +1124,9 @@ private static final class ComplianceFileDescriptorSupplier
private static final class ComplianceMethodDescriptorSupplier
extends ComplianceBaseDescriptorSupplier
implements io.grpc.protobuf.ProtoMethodDescriptorSupplier {
private final String methodName;
private final java.lang.String methodName;

ComplianceMethodDescriptorSupplier(String methodName) {
ComplianceMethodDescriptorSupplier(java.lang.String methodName) {
this.methodName = methodName;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public final class EchoGrpc {

private EchoGrpc() {}

public static final String SERVICE_NAME = "google.showcase.v1beta1.Echo";
public static final java.lang.String SERVICE_NAME = "google.showcase.v1beta1.Echo";

// Static method descriptors that strictly reflect the proto.
private static volatile io.grpc.MethodDescriptor<com.google.showcase.v1beta1.EchoRequest,
Expand Down Expand Up @@ -1004,9 +1004,9 @@ private static final class EchoFileDescriptorSupplier
private static final class EchoMethodDescriptorSupplier
extends EchoBaseDescriptorSupplier
implements io.grpc.protobuf.ProtoMethodDescriptorSupplier {
private final String methodName;
private final java.lang.String methodName;

EchoMethodDescriptorSupplier(String methodName) {
EchoMethodDescriptorSupplier(java.lang.String methodName) {
this.methodName = methodName;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public final class IdentityGrpc {

private IdentityGrpc() {}

public static final String SERVICE_NAME = "google.showcase.v1beta1.Identity";
public static final java.lang.String SERVICE_NAME = "google.showcase.v1beta1.Identity";

// Static method descriptors that strictly reflect the proto.
private static volatile io.grpc.MethodDescriptor<com.google.showcase.v1beta1.CreateUserRequest,
Expand Down Expand Up @@ -631,9 +631,9 @@ private static final class IdentityFileDescriptorSupplier
private static final class IdentityMethodDescriptorSupplier
extends IdentityBaseDescriptorSupplier
implements io.grpc.protobuf.ProtoMethodDescriptorSupplier {
private final String methodName;
private final java.lang.String methodName;

IdentityMethodDescriptorSupplier(String methodName) {
IdentityMethodDescriptorSupplier(java.lang.String methodName) {
this.methodName = methodName;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public final class MessagingGrpc {

private MessagingGrpc() {}

public static final String SERVICE_NAME = "google.showcase.v1beta1.Messaging";
public static final java.lang.String SERVICE_NAME = "google.showcase.v1beta1.Messaging";

// Static method descriptors that strictly reflect the proto.
private static volatile io.grpc.MethodDescriptor<com.google.showcase.v1beta1.CreateRoomRequest,
Expand Down Expand Up @@ -1385,9 +1385,9 @@ private static final class MessagingFileDescriptorSupplier
private static final class MessagingMethodDescriptorSupplier
extends MessagingBaseDescriptorSupplier
implements io.grpc.protobuf.ProtoMethodDescriptorSupplier {
private final String methodName;
private final java.lang.String methodName;

MessagingMethodDescriptorSupplier(String methodName) {
MessagingMethodDescriptorSupplier(java.lang.String methodName) {
this.methodName = methodName;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public final class SequenceServiceGrpc {

private SequenceServiceGrpc() {}

public static final String SERVICE_NAME = "google.showcase.v1beta1.SequenceService";
public static final java.lang.String SERVICE_NAME = "google.showcase.v1beta1.SequenceService";

// Static method descriptors that strictly reflect the proto.
private static volatile io.grpc.MethodDescriptor<com.google.showcase.v1beta1.CreateSequenceRequest,
Expand Down Expand Up @@ -688,9 +688,9 @@ private static final class SequenceServiceFileDescriptorSupplier
private static final class SequenceServiceMethodDescriptorSupplier
extends SequenceServiceBaseDescriptorSupplier
implements io.grpc.protobuf.ProtoMethodDescriptorSupplier {
private final String methodName;
private final java.lang.String methodName;

SequenceServiceMethodDescriptorSupplier(String methodName) {
SequenceServiceMethodDescriptorSupplier(java.lang.String methodName) {
this.methodName = methodName;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public final class TestingGrpc {

private TestingGrpc() {}

public static final String SERVICE_NAME = "google.showcase.v1beta1.Testing";
public static final java.lang.String SERVICE_NAME = "google.showcase.v1beta1.Testing";

// Static method descriptors that strictly reflect the proto.
private static volatile io.grpc.MethodDescriptor<com.google.showcase.v1beta1.CreateSessionRequest,
Expand Down Expand Up @@ -920,9 +920,9 @@ private static final class TestingFileDescriptorSupplier
private static final class TestingMethodDescriptorSupplier
extends TestingBaseDescriptorSupplier
implements io.grpc.protobuf.ProtoMethodDescriptorSupplier {
private final String methodName;
private final java.lang.String methodName;

TestingMethodDescriptorSupplier(String methodName) {
TestingMethodDescriptorSupplier(java.lang.String methodName) {
this.methodName = methodName;
}

Expand Down
Loading