Skip to content

Commit

Permalink
chore: remove library generation IT on workflow (#3476)
Browse files Browse the repository at this point in the history
In this PR:
- Remove library generation integration test run in workflow.
  • Loading branch information
JoeWang1127 authored Dec 19, 2024
1 parent 1d31972 commit c5280d5
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 396 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/verify_library_generation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,29 +38,6 @@ jobs:
head_repo_url: ${{ github.event.pull_request.head.repo.html_url }}
head_repo_name: ${{ github.event.pull_request.head.repo.full_name }}
base_repo: ${{ github.repository }}
library-generation-integration-tests:
runs-on: ubuntu-22.04
needs: should-run-library-generation-tests
if: needs.should-run-library-generation-tests.outputs.should_run == 'true'
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.12
- name: install python modules and dependencies
shell: bash
run: |
set -ex
pip install --upgrade pip
pip install --require-hashes -r hermetic_build/common/requirements.txt
pip install hermetic_build/common
pip install --require-hashes -r hermetic_build/library_generation/requirements.txt
pip install hermetic_build/library_generation
- name: Run integration tests
shell: bash
run: |
set -x
python -m unittest hermetic_build/library_generation/tests/integration_tests.py
library-generation-unit-tests:
runs-on: ubuntu-22.04
needs: should-run-library-generation-tests
Expand Down
2 changes: 1 addition & 1 deletion hermetic_build/library_generation/tests/compare_poms.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""
Utility to compare the contents of two XML files.
Utility to compare the contents of two XML files.
This focuses on the tree structure of both XML files, meaning that element order and whitespace will be disregarded.
The only comparison points are: element path (e.g. project/dependencies) and element text
There is a special case for `dependency`, where the maven coordinates are prepared as well
Expand Down
Loading

0 comments on commit c5280d5

Please sign in to comment.