fix: make workspace plugin with separate-pull-request fine
#2310
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hajime-san
force-pushed
the
fix-workspace-with-separeta-pullrequest
branch
from
044e6af to
a944b75
Compare
src/factories/plugin-factory.ts
Outdated
| @@ -63,6 +65,7 @@ const pluginFactories: Record<string, PluginBuilder> = { | |||
| { | |||
| ...options, | |||
| ...(options.type as WorkspacePluginOptions), | |||
| merge: determineMerge(options), | |||
There was a problem hiding this comment.
This will override the merge option provided by the user (WorkspacePluginOptions has an optional merge).
Also, it seems weird for determineMerge to be checking to see which type of plugin is being configured. determineMerge is already called in a block chosen based on the plugin type. We should just explicitly set the default in the plugin factory for each type.
src/factories/plugin-factory.ts
Outdated
| @@ -38,6 +39,7 @@ export interface PluginFactoryOptions { | |||
| targetBranch: string; | |||
| repositoryConfig: RepositoryConfig; | |||
| manifestPath: string; | |||
| separatePullRequests: boolean; | |||
There was a problem hiding this comment.
This should probably be optional and have a default value. The ability to register plugins and pluginFactories is part of the public API (PluginFactoryOptions). It's unlikely that someone is providing their own PluginFactoryOptions instance, but a default wouldn't hurt.
|
Thank you for checking @chingor13 ! |
[16.14.2](googleapis/release-please@v16.14.1...v16.14.2) (2024-10-08) Bug Fixes java-yoshi: match full artifact id when updating versions (googleapis/release-please#2398) ([e062dc1](googleapis/release-please@e062dc1)) make workspace plugin with separate-pull-request fine (googleapis/release-please#2310) ([15c75a9](googleapis/release-please@15c75a9))
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1858 🦕
If the documentation needs updating, please let me know.