Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass prerelease to buildVersioningStrategy #2133

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

lukekarrys
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2132 🦕

This is a fix for #2132 by passing prerelease to buildVersioningStrategy and updating the appropriate type.

I did not add prerelease as a property to the DefaultVersioningStrategy class since I'm only interested in using it to determine the versioning strategy.

@lukekarrys lukekarrys requested review from a team as code owners November 15, 2023 17:43
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Nov 15, 2023
@lukekarrys lukekarrys force-pushed the lk/most-stale-keyboard branch from 7a06388 to e56b040 Compare November 17, 2023 15:49
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Nov 17, 2023
@chingor13 chingor13 merged commit c9450df into googleapis:main Nov 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access prerelease option when building versioning strategy
2 participants