Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prerelease type #2083

Merged
merged 5 commits into from
Oct 26, 2023
Merged

feat: prerelease type #2083

merged 5 commits into from
Oct 26, 2023

Conversation

kalosisz
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2082 🦕 by introducing an argument to the prerelease versioning strategy.

It also deals with bumping versions with prerelease, but not having a number in the prerelease part in the following ways

  • 2.0.0-beta will get bumped to 2.0.0-beta.1 if there are breaking changes or less
  • 1.2.0-beta will get bumped to 1.2.0-beta.1 if there are featurer or less
  • 1.2.2-beta will get bumped to 1.2.2-beta.1 if there are only patches.

The current behaviour of prelrease, ie. bumping 1.1.1-beta01 to 1.1.1-beta02 is preserved.

@kalosisz kalosisz requested review from a team as code owners September 19, 2023 17:11
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 19, 2023
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. A few minor comments/nits.

docs/manifest-releaser.md Outdated Show resolved Hide resolved
schemas/config.json Outdated Show resolved Hide resolved
test/factory.ts Show resolved Hide resolved
@kalosisz
Copy link
Contributor Author

kalosisz commented Oct 25, 2023

hey @chingor13, please check the changes. thanks

@kalosisz kalosisz requested a review from chingor13 October 25, 2023 07:02
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerelease type for new prerelease versions
2 participants