Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying components by Component commit footer #2031

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

axieum
Copy link
Contributor

@axieum axieum commented Jul 30, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Closes #1905 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 30, 2023
@rozsazoltan
Copy link
Contributor

@axieum This modification will be completed? I find it a very useful idea.

@axieum
Copy link
Contributor Author

axieum commented Dec 5, 2023

@axieum This modification will be completed? I find it a very useful idea.

Please see the comment #1905 (comment) on the original issue. We need to find the best way to approach parsing the commit footers before writing the implementation.

But alas, the failing tests are here and ready for whenever it wants to be picked up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying a component in "Relase-As:", empty commits monorepos
2 participants