ci: set NODE_OPTIONS for node 18

googleapis · Sep 7, 2023 · 454c1d7 · 454c1d7
1 parent 7c7991a
commit 454c1d7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -15,6 +15,9 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node }}
+      - name: Override NODE options for the most recent version
+        if: matrix.node == '18'
+        run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $GITHUB_ENV
       - run: node --version
       # The first installation step ensures that all of our production
       # dependencies work on the given Node.js version, this helps us find

diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
   "scripts": {
-    "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --node-option no-experimental-fetch --recursive --timeout=5000 build/test",
+    "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --recursive --timeout=5000 build/test",
     "docs": "echo add docs tests",
     "test:snap": "SNAPSHOT_UPDATE=1 LC_ALL=en npm test",
     "clean": "gts clean",