Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds pull-request-footer setting #854

Closed
wants to merge 1 commit into from

Conversation

rozsazoltan
Copy link
Contributor

@rozsazoltan rozsazoltan commented Nov 6, 2023

How does it currently work?

There is a template text that gets inserted at the end of the PR code. While reviewing the source code, there is also an opportunity to customize this, but there is no option to provide custom text from a configuration file.

Default footer: This PR was generated with Release Please. See documentation.

Feature

To make the pull request footer text unique, I was created a pull-request-footer setting, similar to customizing the PR header text.

Follow release-please#2115 what merged on [email protected]

@chingor13
Copy link
Contributor

Apologies, but for maintainability, we cannot continue to pass through every configuration option in the form of action inputs.

In v4, we are removing most configuration options which can be set in the manifest configuration file. This will make updating the action with the latest version/features easier and allow folks to debug their configuration using the release-please CLI.

@chingor13 chingor13 closed this Dec 1, 2023
@rozsazoltan
Copy link
Contributor Author

rozsazoltan commented Dec 2, 2023

You have implemented a great solution! This way, there is no need to track the parameters in duplicate anymore.

Solution from v4

We simply use the ready-made solutions from the main release-please project.

release-please-config.json

{
  "pull-request-header": "Your special PR's header here",
  "pull-request-footer": "Your special PR's footer here",
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants