feat(spanner): add support for Multiplexed Session for Read Only Tran… #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
* chore(main): release 7.17.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: surbhigarg92 <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [7.17.1](https://togithub.com/googleapis/nodejs-spanner/compare/v7.17.0...v7.17.1) (2025-01-03) ### Bug Fixes * Remove default global trace context propagator ([#2209](https://togithub.com/googleapis/nodejs-spanner/issues/2209)) ([7898e0c](https://togithub.com/googleapis/nodejs-spanner/commit/7898e0ce0477e2d4327822ac26a2674203b47a64)), closes [#2208](https://togithub.com/googleapis/nodejs-spanner/issues/2208) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
2 times, most recently
from
8a256e0 to
7cf1d60
Compare
alkatrivedi
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
from
7cf1d60 to
9a85b93
Compare
alkatrivedi
added
the
kokoro:force-run
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
from
860bf28 to
47a9219
Compare
yoshi-kokoro
removed
the
kokoro:force-run
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
from
47a9219 to
3a3d8c7
Compare
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
from
3a3d8c7 to
bc56399
Compare
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
from
bc56399 to
f477940
Compare
alkatrivedi
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
…b.com/googleapis/nodejs-spanner into multiplexed-session-support-read-only
…b.com/googleapis/nodejs-spanner into multiplexed-session-support-read-only
kokoro-team
removed
the
kokoro:force-run
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
7 times, most recently
from
000e144 to
fa438fe
Compare
alkatrivedi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
kokoro-team
removed
the
kokoro:force-run
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
from
fa438fe to
270cae3
Compare
alkatrivedi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
surbhigarg92
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
surbhigarg92
approved these changes
Jan 23, 2025
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
4 times, most recently
from
6fe8379 to
7c4f371
Compare
|
|
||
| 'use strict'; | ||
|
|
||
| const muxEnabledTrue = []; |
There was a problem hiding this comment.
nit: I don't think you need to maintain two arrays here. You will either call this script with multiplexedEnabled as true or false. So only one will be used.
| } | ||
|
|
||
| async function runQueries() { | ||
| multiplexedEnabled === 'true' |
There was a problem hiding this comment.
Every thread is creating new Spanner instance, that would mean it will create a new mux session. So eventually we are running only one query at a time for one spanner client.
There was a problem hiding this comment.
thanks for pointing this out, updated the client creation
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
from
7c4f371 to
de2c7ce
Compare
alkatrivedi
force-pushed
the
multiplexed-session-support-read-only
branch
from
48814d8 to
995b31d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains support for Multiplexed Session in all the RO methods, along with their tests.
The methods includes are:
getSnapshotrunStreamwriteAtLeastOnce