Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x-goog-spanner-request-id): add bases #2211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
327 changes: 327 additions & 0 deletions src/request_id_header.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,327 @@
/*!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
/*!
/**

* Copyright 2025 Google LLC. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import {randomBytes} from 'crypto';
import * as grpc from '@grpc/grpc-js';

Check failure on line 18 in src/request_id_header.ts

View workflow job for this annotation

GitHub Actions / lint

"@grpc/grpc-js" is extraneous
const randIdForProcess = randomBytes(8).readBigUint64LE(0).toString();
const X_GOOG_SPANNER_REQUEST_ID_HEADER = 'x-goog-spanner-request-id';

class AtomicCounter {
private backingBuffer: Uint32Array;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private backingBuffer: Uint32Array;
private readonly backingBuffer: Uint32Array;


constructor(initialValue?: number) {
this.backingBuffer = new Uint32Array(
new SharedArrayBuffer(Uint32Array.BYTES_PER_ELEMENT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with this in Node.js, but while looking into what this is, I ran into this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer#security_requirements

Does this affect the usability of this in Node.js? Or is this an issue that is only relevant to code running in a browser?

);
if (initialValue) {
this.increment(initialValue);
}
}

public increment(n?: number): number {
if (!n) {
n = 1;
}
Atomics.add(this.backingBuffer, 0, n);
return this.value();
}

public value(): number {
return Atomics.load(this.backingBuffer, 0);
}

public toString(): string {
return `${this.value()}`;
}

public reset() {
Atomics.store(this.backingBuffer, 0, 0);
}
}

function craftRequestId(
nthClientId: number,
channelId: number,
nthRequest: number,
attempt: number
) {
return `1.${randIdForProcess}.${nthClientId}.${channelId}.${nthRequest}.${attempt}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we add a comment that explains why there is a '1' at the start of this string, e.g.:

// The first digit in this string is the version number of the header type that is used.

}

const nthClientId = new AtomicCounter();

// Only exported for deterministic testing.
export function resetNthClientId() {
nthClientId.reset();
}

/*
* nextSpannerClientId increments the internal
* counter for created SpannerClients, for use
* with x-goog-spanner-request-id.
*/
function nextSpannerClientId(): number {
nthClientId.increment(1);
return nthClientId.value();
}

function newAtomicCounter(n?: number): AtomicCounter {
return new AtomicCounter(n);
}

const X_GOOG_REQ_ID_REGEX = /(\d+\.){5}\d+/;

class XGoogRequestHeaderInterceptor {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, this is a server interceptor, meaning that it will be used for testing, right? Could we then move this to a test file?

private nStream: number;
private nUnary: number;
private streamCalls: any[];
private unaryCalls: any[];
private prefixesToIgnore?: string[];
constructor(prefixesToIgnore?: string[]) {
this.nStream = 0;
this.streamCalls = [];
this.nUnary = 0;
this.unaryCalls = [];
this.prefixesToIgnore = prefixesToIgnore || [];
}

assertHasHeader(call): string | unknown {
const metadata = call.metadata;
const gotReqId = metadata[X_GOOG_SPANNER_REQUEST_ID_HEADER];
if (!gotReqId) {
throw new Error(
`${call.method} is missing ${X_GOOG_SPANNER_REQUEST_ID_HEADER} header`
);
}

if (!gotReqId.match(X_GOOG_REQ_ID_REGEX)) {
throw new Error(
`${call.method} reqID header ${gotReqId} does not match ${X_GOOG_REQ_ID_REGEX}`
);
}
return gotReqId;
}

interceptUnary(call, next) {
const gotReqId = this.assertHasHeader(call);
this.unaryCalls.push({method: call.method, reqId: gotReqId});
this.nUnary++;
next(call);
}

generateClientInterceptor() {
return this.interceptUnary.bind(this);
}

interceptStream(call, next) {
const gotReqId = this.assertHasHeader(call);
this.streamCalls.push({method: call.method, reqId: gotReqId});
this.nStream++;
next(call);
}

generateServerInterceptor() {
return this.serverInterceptor.bind(this);
}

reset() {
this.nStream = 0;
this.streamCalls = [];
this.nUnary = 0;
this.unaryCalls = [];
}

public getUnaryCalls() {
return this.unaryCalls;
}

public getStreamingCalls() {
return this.streamCalls;
}

serverInterceptor(methodDescriptor, call) {
const method = call.handler.path;
const isUnary = call.handler.type === 'unary';
const that = this;

Check failure on line 158 in src/request_id_header.ts

View workflow job for this annotation

GitHub Actions / lint

Unexpected aliasing of 'this' to local variable
const listener = new grpc.ServerListenerBuilder()
.withOnReceiveMetadata((metadata, next) => {
let i = 0;
const prefixesToIgnore: string[] = that.prefixesToIgnore || [];
for (i = 0; i < prefixesToIgnore.length; i++) {
const prefix = prefixesToIgnore[i];
// console.log(`prefix: ${prefix}\nmethod: ${method}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove?

if (method.startsWith(prefix)) {
next(metadata);
return;
}
}

const gotReqIds = metadata.get(X_GOOG_SPANNER_REQUEST_ID_HEADER);
if (!(gotReqIds && gotReqIds.length > 0)) {
call.sendStatus({
code: grpc.status.INVALID_ARGUMENT,
details: `${method} is missing ${X_GOOG_SPANNER_REQUEST_ID_HEADER} header`,
});
return;
}

if (gotReqIds.length !== 1) {
call.sendStatus({
code: grpc.status.INVALID_ARGUMENT,
details: `${method} set multiple ${X_GOOG_SPANNER_REQUEST_ID_HEADER} headers: ${gotReqIds}`,
});
return;
}

const gotReqId = gotReqIds[0].toString();
if (!gotReqId.match(X_GOOG_REQ_ID_REGEX)) {
call.sendStatus({
code: grpc.status.INVALID_ARGUMENT,
details: `${method} reqID header ${gotReqId} does not match ${X_GOOG_REQ_ID_REGEX}`,
});
return;
}

if (isUnary) {
that.unaryCalls.push({method: method, reqId: gotReqId});
that.nUnary++;
} else {
that.streamCalls.push({method: method, reqId: gotReqId});
that.nStream++;
}

next(metadata);
})
.build();

const responder = new grpc.ResponderBuilder()
.withStart(next => next(listener))
.build();
return new grpc.ServerInterceptingCall(call, responder);
}
}

interface withHeaders {
headers: {[k: string]: string};
}

function extractRequestID(config: any): string {
if (!config) {
return '';
}

const hdrs = config as withHeaders;
if (hdrs && hdrs.headers) {
return hdrs.headers[X_GOOG_SPANNER_REQUEST_ID_HEADER];
}
return '';
}

function injectRequestIDIntoError(config: any, err: Error) {
if (!err) {
return;
}

// Inject that RequestID into the actual
// error object regardless of the type.
const requestID = extractRequestID(config);
if (requestID) {
Object.assign(err, {requestID: requestID});
}
}

interface withNextNthRequest {
_nextNthRequest: Function;
}

interface withMetadataWithRequestId {
_nthClientId: number;
_channelId: number;
}

function injectRequestIDIntoHeaders(
headers: {[k: string]: string},
session: any,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this typed?

nthRequest?: number,
attempt?: number
) {
if (!session) {
return headers;
}

if (!nthRequest) {
const database = session.parent as withNextNthRequest;
if (!(database && typeof database._nextNthRequest === 'function')) {
return headers;
}
nthRequest = database._nextNthRequest();
}

attempt = attempt || 1;
return _metadataWithRequestId(session, nthRequest!, attempt, headers);
}

function _metadataWithRequestId(
session: any,
nthRequest: number,
attempt: number,
priorMetadata?: {[k: string]: string}
): {[k: string]: string} {
if (!priorMetadata) {
priorMetadata = {};
}
const withReqId = {
...priorMetadata,
};
const database = session.parent as withMetadataWithRequestId;
let clientId = 1;
let channelId = 1;
if (database) {
clientId = database._nthClientId || 1;
channelId = database._channelId || 1;
}
withReqId[X_GOOG_SPANNER_REQUEST_ID_HEADER] = craftRequestId(
clientId,
channelId,
nthRequest,
attempt
);
return withReqId;
}

function nextNthRequest(database): number {
if (!(database && typeof database._nextNthRequest === 'function')) {
return 1;
}
return database._nextNthRequest();
}

export interface RequestIDError extends grpc.ServiceError {
requestID: string;
}

export {
AtomicCounter,
X_GOOG_SPANNER_REQUEST_ID_HEADER,
XGoogRequestHeaderInterceptor,
craftRequestId,
injectRequestIDIntoError,
injectRequestIDIntoHeaders,
nextNthRequest,
nextSpannerClientId,
newAtomicCounter,
randIdForProcess,
};
Loading
Loading