Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove native image sample in favor of sample hosted in google-cloud-java #3210

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

mpeddada1
Copy link
Contributor

This PR removes the library-specific Spanner native image sample in favor of a single sample maintained in https://github.com/googleapis/google-cloud-java/tree/main/java-samples/native-image-sample which serves the same purposes of showcasing how to build a native image for a client library.

Documented externally in https://cloud.google.com/java/docs/compile-native-images#whats_next

@mpeddada1 mpeddada1 requested review from a team as code owners July 12, 2024 19:55
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jul 12, 2024
Copy link

generated-files-bot bot commented Jul 12, 2024

Warning: This pull request is touching the following templated files:

  • samples/pom.xml

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Jul 12, 2024
Copy link

snippet-bot bot commented Aug 27, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@mpeddada1 mpeddada1 force-pushed the remove-native-image-sample branch from 87418b5 to d998788 Compare August 27, 2024 15:35
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 27, 2024
@mpeddada1 mpeddada1 force-pushed the remove-native-image-sample branch from d998788 to 707c33a Compare August 27, 2024 15:40
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Aug 27, 2024
@mpeddada1 mpeddada1 requested a review from rahul2393 August 27, 2024 15:51
@rahul2393 rahul2393 merged commit 7d8426a into main Aug 28, 2024
32 of 33 checks passed
@rahul2393 rahul2393 deleted the remove-native-image-sample branch August 28, 2024 16:03
lqiu96 pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants