Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Dont depend on google-cloud-bom. causes a circular dependency. #1760

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

bcol-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@bcol-google bcol-google requested review from a team as code owners October 25, 2024 21:13
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsublite Issues related to the googleapis/java-pubsublite API. labels Oct 25, 2024
Copy link
Contributor Author

@bcol-google bcol-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcol-google bcol-google merged commit dcc9295 into googleapis:main Oct 25, 2024
20 checks passed
@blakeli0
Copy link

For future improvements, we can import the pubsub bom in dependencyManagement section, so that we don't have to specify two versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants