chore: Override the version of protobuf-bom to 4.28.3 in libraries-bom. #6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
commented
Oct 30, 2024
| @@ -182,6 +182,9 @@ private void printKeyCoreLibraryDependencies(Bom bom) { | |||
| .append("- Google Cloud Core: ") | |||
| .append(versionlessCoordinatesToVersion.get("com.google.cloud:google-cloud-core")) | |||
| .append("\n"); | |||
| report | |||
There was a problem hiding this comment.
I was considering adding a unit test for it, but looks like we don't have any for this Core Library Dependencies section.
suztomo
reviewed
Oct 30, 2024
lqiu96
reviewed
Oct 30, 2024
release-note-generation/src/main/java/com/google/cloud/ReleaseNoteGeneration.java
Outdated
Show resolved
Hide resolved
lqiu96
approved these changes
Oct 30, 2024
suztomo
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
protobuf-bomsection tolibraries-bomto override the protobuf runtime version to the latest.libraries-bom-protobuf3if there is any incompatibility issues.libraries-bom-protobuf3to match the version oflibraries-bom.protobuf-bomfrom being updated by renovate bot.