Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore grpc-binder and grpc-cronet in bom validation #6191

Merged
merged 11 commits into from
Sep 19, 2023
14 changes: 7 additions & 7 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
matrix:
java: [11, 17]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
Expand All @@ -41,7 +41,7 @@ jobs:
name: "units (8)"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
java-version: 8
Expand All @@ -63,7 +63,7 @@ jobs:
steps:
- name: Support longpaths
run: git config --system core.longpaths true
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
Expand All @@ -78,7 +78,7 @@ jobs:
matrix:
java: [17]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
Expand All @@ -88,7 +88,7 @@ jobs:
javadoc:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
Expand All @@ -100,7 +100,7 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
Expand All @@ -112,7 +112,7 @@ jobs:
clirr:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,16 @@ private static String calculateDependenciesSection(Bom bom) {
continue;
}

// Skipping grpc-android as it is not used by Google Cloud Client Libraries for Java. Checking
// for availability of
// this unused artifact on Maven Central has caused BOM validation check to fail in the past.
// Skipping grpc-android, grpc-binder and grpc-cronet as they are not used by Google Cloud
// Client
// Libraries for Java. Checking for availability of these unused artifacts on Maven Central
// has
mpeddada1 marked this conversation as resolved.
Show resolved Hide resolved
// caused BOM validation check to fail in the past.
// See
// https://github.com/googleapis/sdk-platform-java/pull/1989#issuecomment-1724039670
if ("grpc-android".equals(managedDependency.getArtifactId())) {
if ("grpc-android".equals(managedDependency.getArtifactId())
|| "grpc-binder".equals(managedDependency.getArtifactId())
|| "grpc-cronet".equals(managedDependency.getArtifactId())) {
continue;
}

Expand Down