Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING_CHANGE: [vertexai] Change VertexAI to Builder pattern and remove setters. #10600

Merged
merged 1 commit into from
Mar 22, 2024
Merged

BREAKING_CHANGE: [vertexai] Change VertexAI to Builder pattern and remove setters. #10600

merged 1 commit into from
Mar 22, 2024

Conversation

copybara-service[bot]
Copy link
Contributor

BREAKING_CHANGE: [vertexai] Change VertexAI to Builder pattern and remove setters.

@copybara-service copybara-service bot requested review from a team as code owners March 21, 2024 22:28
ZhenyiQ
ZhenyiQ approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ZhenyiQ ZhenyiQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved internally.

@ZhenyiQ ZhenyiQ enabled auto-merge (squash) March 22, 2024 01:41
@ZhenyiQ ZhenyiQ merged commit 42e806e into main Mar 22, 2024
31 checks passed
@ZhenyiQ ZhenyiQ deleted the copybara_617935686 branch March 22, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhenyiQ ZhenyiQ ZhenyiQ approved these changes

Assignees
No one assigned
Labels
google-vertexai-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ZhenyiQ