fix: createURI() should not persist uri (#437)

src/index.ts

@@ -310,10 +310,11 @@ export class Upload extends Pumpify {
       if (this.uri) {
         this.continueUploading();
       } else {
-        this.createURI(err => {
+        this.createURI((err, uri) => {
           if (err) {
             return this.destroy(err);
           }
+          this.set({uri});
           this.startUploading();
         });
       }
@@ -374,7 +375,6 @@ export class Upload extends Pumpify {
     const resp = await this.makeRequest(reqOpts);
     const uri = resp.headers.location;
     this.uri = uri;
-    this.set({uri});
     this.offset = 0;
     return uri;
   }
@@ -614,10 +614,11 @@ export class Upload extends Pumpify {
     this.emit('restart');
     this.numBytesWritten = 0;
     this.deleteConfig();
-    this.createURI(err => {
+    this.createURI((err, uri) => {
       if (err) {
         return this.destroy(err);
       }
+      this.set({uri});
       this.startUploading();
     });
   }

test/test.ts

@@ -322,6 +322,18 @@ describe('gcs-resumable-upload', () => {
         };
         up.emit('writing');
       });
+
+      it('should save the uri to config on first write event', done => {
+        const uri = 'http://newly-created-uri';
+        up.createURI = (callback: CreateUriCallback) => {
+          callback(null, uri);
+        };
+        up.set = (props: {}) => {
+          assert.deepStrictEqual(props, {uri});
+          done();
+        };
+        up.emit('writing');
+      });
     });
   });
 
@@ -403,15 +415,6 @@ describe('gcs-resumable-upload', () => {
         });
       });
 
-      it('should save the uri to config', done => {
-        up.set = (props: {}) => {
-          assert.deepStrictEqual(props, {uri: URI});
-          done();
-        };
-
-        up.createURI(assert.ifError);
-      });
-
       it('should default the offset to 0', done => {
         up.createURI((err: Error) => {
           assert.ifError(err);
@@ -1170,6 +1173,21 @@ describe('gcs-resumable-upload', () => {
         up.restart();
       });
 
+      it('should save the uri to config when restarting', done => {
+        const uri = 'http://newly-created-uri';
+
+        up.createURI = (callback: Function) => {
+          callback(null, uri);
+        };
+
+        up.set = (props: {}) => {
+          assert.deepStrictEqual(props, {uri});
+          done();
+        };
+
+        up.restart();
+      });
+
       it('should start uploading', done => {
         up.createURI = (callback: Function) => {
           up.startUploading = done;