Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump pkg version to v8.2.1 #939

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

antongolub
Copy link
Collaborator

closes #938

@jlbribeiro
Copy link

Hey @antongolub thank you for addressing this so quickly! I thought of doing this PR, but (possibly a noob question, as I've never done release management on GitHub): isn't the release associated to a Git tag? Meaning: installs of the 8.2.1 tag/release will still have the incorrect 8.2.0 package.json, correct? (which means the CLI will still report 8.2.0 if not installed from the main branch)

@antongolub
Copy link
Collaborator Author

We use a pair of triggers to publish npm pkg: release tag and manual dispatch

name: Publish

on:
  workflow_dispatch:
  release:
    types: [created]

So, as soon as this PR is merged, the npm pkg will be published by click

@jlbribeiro
Copy link

jlbribeiro commented Nov 8, 2024

@antongolub Thank you for your reply; if that means the Git tag (and GitHub release) will be overwritten to point to the new commit, then that's fixed. (but I was under the impression Git tags don't get overwritten, hence the original question). Apologies for the noise. If this doesn't address my concerns, I'll have to pin by commit instead, which is ok.

(full context of the original (#938) issue) The nixpkgs package is built from source, based on the git tag; it's the mismatch between the Git tag and the package.json version that ends up being the problem in my particular case; I was under the impression that overwriting Git tags was not "common". Thank you!

@antongolub
Copy link
Collaborator Author

We can just move the release tag to the next commit as an option too.

@antonmedv antonmedv merged commit 0f2be5b into google:main Nov 9, 2024
21 checks passed
@jlbribeiro jlbribeiro mentioned this pull request Nov 10, 2024
13 tasks
jlbribeiro added a commit to jlbribeiro/nixpkgs that referenced this pull request Nov 10, 2024
Diff: google/[email protected]
Changelog: https://github.com/google/zx/releases/tag/8.2.1

Temporarily pinning the commit which modifies package.json,
as that affects the version reported by the CLI
(causing `versionCheckHook` to fail).

0f2be5b053b7649fca84c92cd04310b94e297413~ == refs/tags/8.2.1

See:
- google/zx#938
- google/zx#939
jlbribeiro added a commit to jlbribeiro/nixpkgs that referenced this pull request Nov 13, 2024
Diff: google/zx@8.2.0...8.2.1
Changelog: https://github.com/google/zx/releases/tag/8.2.1

Temporarily pinning the commit which modifies package.json,
as that affects the version reported by the CLI
(causing `versionCheckHook` to fail).

0f2be5b053b7649fca84c92cd04310b94e297413~ == refs/tags/8.2.1

See:
- google/zx#938
- google/zx#939
jlbribeiro added a commit to jlbribeiro/nixpkgs that referenced this pull request Nov 13, 2024
Diff: google/zx@8.2.0...8.2.1
Changelog: https://github.com/google/zx/releases/tag/8.2.1

Temporarily pinning the commit which modifies package.json,
as that affects the version reported by the CLI
(causing `versionCheckHook` to fail).

0f2be5b053b7649fca84c92cd04310b94e297413~ == refs/tags/8.2.1

See:
- google/zx#938
- google/zx#939
@antongolub
Copy link
Collaborator Author

antongolub commented Nov 13, 2024

@jlbribeiro

fyi, 8.2.2 is definitely in sync.

@antongolub antongolub deleted the pkg-8-2-1 branch November 13, 2024 08:36
@jlbribeiro
Copy link

@antongolub Thank you for the ping (and apologies for the spam above!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 8.2.1 with incorrect package.json version
3 participants