ci: enforce Pinned-Dependencies check in CI for PRs #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
=======================================
Coverage 89.46% 89.46%
=======================================
Files 16 16
Lines 5838 5838
=======================================
Hits 5223 5223
Misses 615 615 ☔ View full report in Codecov by Sentry. |
joshlf
requested changes
Oct 31, 2024
There was a problem hiding this comment.
See this CI failure; you'll also need to add a dependency on this job to all-jobs-succeeded.
.github/workflows/scorecard.yml
Outdated
| @@ -16,11 +16,14 @@ on: | |||
| # https://github.com/ossf/scorecard/blob/main/docs/checks.md#branch-protection | |||
| branch_protection_rule: | |||
| # To guarantee Maintained check is occasionally updated. See | |||
| # https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained | |||
| # https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintaineds | |||
There was a problem hiding this comment.
Typo? Looks like the old link is the correct one
.github/workflows/scorecard.yml
Outdated
| @@ -32,7 +35,7 @@ jobs: | |||
| permissions: | |||
| # Needed to upload the results to code-scanning dashboard. | |||
| security-events: write | |||
| # Needed to publish results and get a badge (see publish_results below). | |||
|
Thanks for doing this! Just a few small changes, but otherwise this looks good! |
Aditya-PS-05
force-pushed
the
add/pinned-dependencies-check-ci
branch
from
743da92
to
510c8fb
Compare
|
@jswrenn , I request you to review this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1579