Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[byteorder] Impl traits for byte arrays #1785

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Sep 30, 2024

Closes #1749

@joshlf joshlf marked this pull request as draft September 30, 2024 23:48
Copy link
Member Author

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  • Audit impls for correctness (I banged them out pretty mechanically, so there could be endianness errors)
  • Tests

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.58065% with 24 lines in your changes missing coverage. Please review.

Project coverage is 87.11%. Comparing base (ea28664) to head (8398b2d).

Files with missing lines Patch % Lines
src/byteorder.rs 22.58% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1785      +/-   ##
==========================================
- Coverage   87.46%   87.11%   -0.35%     
==========================================
  Files          16       16              
  Lines        6021     6048      +27     
==========================================
+ Hits         5266     5269       +3     
- Misses        755      779      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[byteorder] Support trait impls on byte arrays
2 participants