Avoid nightly regression by using older nightly #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightly-2023-12-15 breaks compilation of native applets by having symbols from `compiler_builtins` conflict between the applet static library and the platform during linking. This was not the case with nightly-2023-11-14. This rollback is temporary until rust-lang/rust#118609 is fixed or provides guidance on how to address this issue. Currently the only work-arounds are: - Compile the applet to an object file (like `applet.o`) and let the platform link all the dependencies of the applet. This is not obvious to do generically at the moment. - Require applets that need to compile natively to directly depend on `compiler_builtins` with the `weak-intrinsics` feature. If the dependency could been indirect, the prelude would have been the perfect place to introduce it. But given the dependency must be direct, this adds a small burden on applets.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Jan 15, 2024
The previous one was broken and rolled-back in google#338.
ia0
added a commit
to ia0/wasefire
that referenced
this pull request
Jan 15, 2024
Now that rust-lang/rust#118609 is fixed. The previous nightly was broken and rolled-back in google#338.
ia0
added a commit
that referenced
this pull request
Jan 15, 2024
Now that rust-lang/rust#118609 is fixed. The previous nightly was broken and rolled-back in #338.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nightly-2023-12-15 breaks compilation of native applets by having symbols from
compiler_builtinsconflict between the applet static library and the platform during linking. This was not the case with nightly-2023-11-14.This rollback is temporary until rust-lang/rust#118609 is fixed or provides guidance on how to address this issue. Currently the only work-arounds are:
Compile the applet to an object file (like
applet.o) and let the platform link all the dependencies of the applet. This is not obvious to do generically at the moment.Require applets that need to compile natively to directly depend on
compiler_builtinswith theweak-intrinsicsfeature. If the dependency could been indirect, the prelude would have been the perfect place to introduce it. But given the dependency must be direct, this adds a small burden on applets.