Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed getting started links #307

Closed
wants to merge 1 commit into from

Conversation

javiber
Copy link
Collaborator

@javiber javiber commented Nov 13, 2023

A couple of links in the readme were broken. They were pointing to (what seems like) an old location of the "Getting started" section

Copy link

google-cla bot commented Nov 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@ianspektor ianspektor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting started's path was updated in #293, its broken in the README atm because we haven't released yet (so the changes aren't in /stable in the docs). We should either release more often (though the manual part makes that not too desirable), or maybe point the README's links to /latest?

@DonBraulio
Copy link
Collaborator

Agree with @ianspektor, it's time to make a new release because the changes in the docs are significant.
I'd keep this PR open until the new version is released, to not forget about it 😄

About changing to /latest... I'm not sure, most people will just do pip install temporian so I think that pointing to stable is the right thing. Although it's a bit annoying that changing the docs in any way requires a new release for the users to actually see it, imo it's a good thing to release more often at this stage of the project.

@javiber
Copy link
Collaborator Author

javiber commented Nov 15, 2023

Agree with you guys, I think it makes sense to just close this one so I will do that.

@javiber javiber closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants