-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-fno-rtti
incompatible with UBSAN fuzzing setup
#189
Comments
This was referenced Aug 9, 2024
It seems that this will not be accepted. See also: #147 |
kou
added a commit
to apache/arrow
that referenced
this issue
Aug 16, 2024
### Rationale for this change Snappy's CMakeLists.txt unconditionally disables RTTI. This is incompatible with some other options, such as activating UBSAN for a fuzzing build: google/snappy#189 ### What changes are included in this PR? Add `-frtti` at the end of compiler options when compiling a bundled Snappy build. ### Are these changes tested? On CI; also manually checked that this allows enabling Snappy on OSS-Fuzz builds. ### Are there any user-facing changes? No. * GitHub Issue: #43688 Lead-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
I am ok with the idea of removing fno-rtti but I am afraid this is going to break ABI for quite a few users. Need to think and research how it affects ABI, maybe it's just for weird cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have Apache Arrow set up on OSS-Fuzz. Arrow can optionally use Snappy to read Parquet files, but unfortunately Snappy cannot be enabled on some OSS-Fuzz builders because of incompatible compiler options.
See attempted CI run here:
https://github.com/google/oss-fuzz/actions/runs/10306444556/job/28529568675
and in particular these errors:
It would be nice if Snappy didn't force
-fno-rtti
unconditionally.The text was updated successfully, but these errors were encountered: