GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled #43706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g python |
This comment was marked as outdated.
This comment was marked as outdated.
|
cc @kou |
|
CI failures are unrelated. |
kou
approved these changes
Aug 15, 2024
| set(SNAPPY_ADDITIONAL_CXX_FLAGS "${SNAPPY_ADDITIONAL_CXX_FLAGS} -frtti") | ||
| endif() | ||
|
|
||
| if(NOT MSVC) |
There was a problem hiding this comment.
No, we cannot, see build error in https://github.com/apache/arrow/actions/runs/10401760097/job/28804899409
There was a problem hiding this comment.
Ah, https://github.com/apache/arrow/pull/43706/files#r1719156798 will fix it. I'll try it.
github-actions
bot
added
awaiting merge
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
kou
reviewed
Aug 16, 2024
github-actions
bot
added
awaiting changes
|
@github-actions crossbow submit -g cpp -g python |
github-actions
bot
added
awaiting change review
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g cpp -g python |
|
Revision: 1d0aefa Submitted crossbow builds: ursacomputing/crossbow @ actions-5b7a47bd42
|
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit a970fd7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 143 possible false positives for unstable benchmarks that are known to sometimes produce them. |
DavidKorczynski
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Aug 21, 2024
In PR #12320, we enabled more compression algorithms for Arrow C++, but had to disable Snappy because of build issues. Since then, the Arrow project merged a PR (apache/arrow#43706) which enables RTTI when building Snappy. Therefore, we can now enable Snappy in the OSS-Fuzz builds of Arrow C++ as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Snappy's CMakeLists.txt unconditionally disables RTTI. This is incompatible with some other options, such as activating UBSAN for a fuzzing build:
google/snappy#189
What changes are included in this PR?
Add
-frttiat the end of compiler options when compiling a bundled Snappy build.Are these changes tested?
On CI; also manually checked that this allows enabling Snappy on OSS-Fuzz builds.
Are there any user-facing changes?
No.