This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Fixes to work with TensorFlow 1.2 #254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following error when running the tests on Python 3.
Traceback (most recent call last):
File "seq2seq/seq2seq/test/hooks_test.py", line
55, in test_begin
self.assertEqual(file_contents.decode(), ...)
AttributeError: 'str' object has no attribute 'decode'
distutils.version isn't available on the CI versions, so change the test to not rely explicitly on the version of TensorFlow installed.
|
Phew. A couple of failed attempts against CircleCI, but hopefully useful now it works. :) |
Use of `tf.name_scope` and `tf.variable_scope` cause pylint errors on TF1.2 due to pylint not fully understanding the `tf_contextlib.contextmanager` decorators.
Following some changes in TF to the `LazyLoader` [1], pylint complains
about not being able to find some imports under `tf.contrib`. This looks
like a pylint issue, emitting errors like:
************* Module seq2seq.encoders.rnn_encoder
E: 24, 0: No name 'rnn' in module 'LazyLoader' (no-name-in-module)
************* Module seq2seq.data.input_pipeline
E: 32, 0: No name 'slim' in module 'LazyLoader' (no-name-in-module)
[1] tensorflow/tensorflow@95c5d7e
|
Not sure what the deal is about author consent. I err, consent. |
|
FYI, this seems to work for me when getting the simple pipeline test to run |
|
I think I need to say "I consent" again. |
|
What is the plan for this fork? When will it be released? Thanks! |
cemheren
approved these changes
Aug 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor, albeit ugly, fixes to support TF1.2 - tested against 1.2.0-rc1.
I've checked these don't break the tests for the current TF1.1 version.