Skip to content

Commit

Permalink
Fix an admin_config bug by passing in a non-empty dummy ACL.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 586481840
Change-Id: Ib4d6a94e850354a7be1e92f3efb7c969edec31cd
  • Loading branch information
jiawenhao authored and copybara-github committed Nov 30, 2023
1 parent 6cde791 commit 422fe77
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions saxml/bin/admin_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ import (
)

var (
saxCell = flag.String("sax_cell", "", "Sax cell, e.g., /sax/test")
fsRoot = flag.String("fs_root", "", "FS root, e.g., /tmp/sax-fs-root")
saxCell = flag.String("sax_cell", "", "Sax cell, e.g., /sax/test")
fsRoot = flag.String("fs_root", "", "FS root, e.g., /tmp/sax-fs-root")
adminACL = flag.String("admin_acl", "acl/all", "Admin ACL, e.g., acl/all")
)

func main() {
Expand Down Expand Up @@ -57,7 +58,9 @@ func main() {
}

// Write a Sax config.proto file into the Sax cell subdirectory in the Sax root directory.
if err := config.Create(ctx, *saxCell, *fsRoot, ""); err != nil {
// The Cloud platform ignores all admin ACLs but requires a non-empty value. The value itself
// doesn't matter, so just pass in the default value.
if err := config.Create(ctx, *saxCell, *fsRoot, *adminACL); err != nil {
log.Fatalf("Failed to create config: %v", err)
}
}

0 comments on commit 422fe77

Please sign in to comment.