fix: Improve the accuracy of the coverage report. #296
Conversation
clydegerber
commented
Nov 5, 2023
•
clydegerber
commented
- Ignore trailing '()' characters in function names when reporting coverage.
- Only track functions that match a function in the header file of interest as implemented.
- Mark the uenum::uloc_open_keywords as deprecated, copy the implementation into the uloc crate and copy the test that was in the uloc crate into the uenum crate so that it is still protected by a test even though deprecated.
…ments when tracking coverage and implement some warning messages to highlight discrepancies in coverage tracking.
coverage/report.md
Outdated
| @@ -205,6 +205,13 @@ | |||
| | `udat_toPatternRelativeDate` | | | |||
| | `udat_toPatternRelativeTime` | | | |||
| | `udat_unregisterOpener` | | | |||
| Warning: Implemented + Unimplemented != Total | |||
There was a problem hiding this comment.
Is the question about the clarity of the message or the existence of the message? If it is about clarity, would something like "Warning: Count of total C API functions is not equal to the sum of the counts of implemented and non-implemented functions" be clearer?
There was a problem hiding this comment.
An alternative would be to add a screen to the '*_implemented.txt' file creation to ignore functions that aren't in the C API for the given header file.
|
Is it possible to use the canonical git commit messages, with a short one-line summary, and a slightly longer synopsis? E.g. like https://www.conventionalcommits.org/en/v1.0.0/#summary - though I'm not a stickler to the specific format. |
Can do! |
- Ignore trailing '()' characters in function names when reporting coverage. - Only track functions that match a function in the header file of interest as implemented. - Mark the uenum::uloc_open_keywords as deprecated, copy the implementation into the uloc crate and copy the test that was in the uloc crate into the uenum crate so that it is still protected by a test even though deprecated.
clydegerber
changed the title
