Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the resolver version to 2, clarify the error message when the ICU… #290

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

clydegerber
Copy link
Contributor

@clydegerber clydegerber commented Oct 25, 2023

… version isn't found and add implementations for ICU functions:

  • uloc_getName(),
  • uloc_getISO3Language(),
  • uloc_getISO3Country(),
  • uloc_getDisplayLanguage(),
  • uloc_getDisplayScript(),
  • uloc_getDisplayCountry(),
  • uloc_getDisplayVariant(),
  • uloc_getDisplayKeyword(),
  • uloc_getDisplayKeywordValue(), and
  • uloc_getDisplayName()).

@google-cla
Copy link

google-cla bot commented Oct 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

… version isn't found and add implementations for ICU functions:

- uloc_getName(),
- uloc_getISO3Language(),
- uloc_getISO3Country(),
- uloc_getDisplayLanguage(),
- uloc_getDisplayScript(),
- uloc_getDisplayCountry(),
- uloc_getDisplayVariant(),
- uloc_getDisplayKeyword(),
- uloc_getDisplayKeywordValue(), and
- uloc_getDisplayName()).
@filmil
Copy link
Member

filmil commented Oct 25, 2023

Your new tests are failing likely because the old ICU data does not have all the locale information present in more modern ICU versions, causing different results.

You may want to add a config flag on the value of icu_version_67_plus on the affected tests, causing them to be skipped when compiled with ICU v63.

#[cfg(feature = "icu_version_67_plus")]

(In general I recommend depending less on the exact text in the ICU data responses as ICU data tends to change frequently. But I admit this is something I did early on too.)

@filmil filmil merged commit d02f582 into google:main Oct 25, 2023
15 checks passed
@filmil
Copy link
Member

filmil commented Oct 25, 2023

Merged. Thank you for your contribution!

@filmil filmil self-requested a review October 25, 2023 19:24
@clydegerber clydegerber deleted the bugfix/uloc_for_lang branch October 25, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants