Move linking flags to build.rs to help with non-cargo build systems #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using
rust_icu
with Bazel, I realized that the#[cfg_attr]
attributes in the code make everything difficult.This brings the following improvement:
build.rs
enables buildingrust_icu
with Bazel (which can skip using thebuild.rs
file)RUST_ICU_LINK_SEARCH_DIR
environment variable when you need to use a non-installed build oficu4c
static
feature and add a CI job to test this for both Ubuntu and macOS