Add the GetPlatformInfo action #55
Conversation
| fn main() { | ||
| #[cfg(all(target_os = "linux", feature = "action-platform-info"))] | ||
| { | ||
| println!("cargo:rerun-if-changed=src/action/libc_version.c"); | ||
|
|
||
| cc::Build::new() | ||
| .file("src/action/libc_version.c") | ||
| .compile("liblibc_version.a"); | ||
| } | ||
| } |
There was a problem hiding this comment.
I am affraid build script is not an option — this does not play well with our internal build infrastructure (for rrg-proto I already have to do some awkward workarounds).
There was a problem hiding this comment.
Yes, we can scrap the build script. The libc::gnu_get_libc_version function is now available in the standard library.
| cocoa = { git = "https://github.com/servo/core-foundation-rs.git", rev = "786895643140fa0ee4f913d7b4aeb0c4626b2085", optional = true } | ||
| objc = { version = "0.2", optional = true } |
There was a problem hiding this comment.
These seem like a quite heavy dependencies, I wonder if there is a way to avoid these. Moreover, I would prefer not to depend on anything that is not on crates.io because of our internal build infrastructure.
| #include <features.h> | ||
| #ifdef __GNU_LIBRARY__ | ||
| #include <gnu/libc-version.h> | ||
| #else | ||
| #include <stddef.h> | ||
| #endif | ||
|
|
||
| const char *libc_version(void) { | ||
| #ifdef __GNU_LIBRARY__ | ||
| return gnu_get_libc_version(); | ||
| #else | ||
| return NULL; | ||
| #endif | ||
| } |
There was a problem hiding this comment.
What is the benefit over libc::gnu_get_libc_version?
There was a problem hiding this comment.
Yes, excellent. I did not know that the gnu_get_* APIs were added recently
| /// The system platform (Windows|Darwin|Linux). | ||
| system: String, |
| /// The architecture of this binary. (Note this can be different from | ||
| /// the machine architecture in the case of a 32 bit binary running | ||
| /// on a 64 bit system) | ||
| architecture: String, |
There was a problem hiding this comment.
Since this just uses std::env::consts::ARCH this can be typed as &'static str.
Adds the GetPlatformInfo action.
The implementation is following the Python cpython runtime, but is not as backwards compatible.
Known compatibility requirements
Comparison matrix table of the protocol buffer properties (source code)
systemnodereleaseversionmachinekernelfqdninstall_datelibc_verarchitecturepep425tagDifferences (marked with an asterisk * in the comparison matrix table above)
releaseandversionproperties. As the library is quite extensive (source code), the raw values from libc::utsname are used instead. The conversion to a human readable format should be done on the server.pep425tagproperty is always unset, as it only exists on Python to identify the unique signature of a Python runtime (PEP 425 specification).libc_versionproperty is only set, if the client was compiled against the GNU libc library.releaseproperty is hardcoded and set to the value "OSX" by default, similar to the grr client (source code).versionproperty is set using the NSProcessInfo.processInfo function. The interface containing the operating system version is available equal to or after MacOS 10.10. In the Python cpython runtime implementation, the MacOS version is read using the SystemVersion.plist file (source code).systemproperty is hardcoded and set to the value "Windows" by default.versionproperty does not include the service pack version. The service pack version can be read using the GetVersionExA function, but this function might be altered or unavailable for releases after Windows 8.1. The concept of service packs is obsolete since Windows 10.machineproperty is set using the GetVersion function and uses the SYSTEM_INFO structure to determine the processor architecture.Example - Linux
PlatformInfo { system: "Linux", node: "fv-az371-529", release: "5.15.0-1022-azure", version: Some("#27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022"), machine: Some("x86_64"), kernel: "5.15.0-1022-azure", fqdn: "fv-az371-529.ipdn00qvwfrujbrcphh0gwusye.dx.internal.cloudapp.net", install_date: Some(SystemTime { tv_sec: 1667763649, tv_nsec: 0 }), libc_ver: Some("2.31"), architecture: "x86_64" }Example - MacOS
PlatformInfo { system: "Darwin", node: "Mac-1667763736626.local", release: "OSX", version: Some("12.6.1"), machine: Some("x86_64"), kernel: "21.6.0", fqdn: "mac-1667763736626.local", install_date: Some(SystemTime { tv_sec: 1667763649, tv_nsec: 480097701 }), libc_ver: None, architecture: "x86_64" }Example - Windows
PlatformInfo { system: "Windows", node: "fv-az449-397", release: "10", version: Some("10.0 (20348)"), machine: Some("x86_64"), kernel: "10.0.20348 Build 20348", fqdn: "fv-az449-397", install_date: Some(SystemTime { intervals: 133117186730000000 }), libc_ver: None, architecture: "x86_64" }References
Resolves #6