Skip to content

Commit

Permalink
sdk: change C++ standard to 17 in cmake
Browse files Browse the repository at this point in the history
Also fixed some leftover docs/README/comments to C++17.

Change-Id: Iee6ff469741739372472d997d193e871cc2447f2
  • Loading branch information
LalitMaganti committed Nov 9, 2022
1 parent 2ed57ec commit 6afd9d7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/contributing/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## Repository

This project uses [Android AOSP Gerrit][perfetto-gerrit] for code reviews,
follows the [Google C++ style][google-cpp-style], and targets `-std=c++11`.
follows the [Google C++ style][google-cpp-style], and targets `-std=c++17`.

Development happens in the AOSP repository:
https://android.googlesource.com/platform/external/perfetto/
Expand Down
2 changes: 1 addition & 1 deletion examples/sdk/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
cmake_minimum_required(VERSION 3.13)
project(perfetto-sdk-example)

set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

find_package(Threads)
Expand Down
2 changes: 1 addition & 1 deletion gn/standalone/libc++/libc++.gni
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ declare_args() {
# build/config/c++/c++.gni)
# 2) The libstdc++ situation is too wild on Linux. Modern debian distros are
# fine but Ubuntu Trusty still ships a libstdc++ that doesn't fully
# support C++11. Hence we enable this flag on Linux by default.
# support C++17. Hence we enable this flag on Linux by default.
# We still retain libstdc++ coverage on the CI bots by overriding
# use_custom_libcxx=false when we target a modern library (see the
# GCC target in infra/ci/config.py).
Expand Down
2 changes: 1 addition & 1 deletion src/tracing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ at a source-code level.
**Both have the following sub-structure**:

`{include,src}/core/`
"Core" is the pure c++11 tracing machinery that deals with bookkeeping,
"Core" is the pure c++17 tracing machinery that deals with bookkeeping,
ring-buffering, partitioning and multiplexing but knows nothing about
platform-specific things like implementation of shared memory and RPC mechanism.

Expand Down

0 comments on commit 6afd9d7

Please sign in to comment.