Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(container-scanning): set unimportant vulns as uncalled #1385

Merged
merged 3 commits into from
Nov 8, 2024
Merged

feat(container-scanning): set unimportant vulns as uncalled #1385

merged 3 commits into from
Nov 8, 2024

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Nov 7, 2024 •
edited
Loading

Resolves #1378

@G-Rath
Copy link
Collaborator

G-Rath commented Nov 7, 2024

fwiw "solves" is not an issue-closing-trigger-word (a term I just made up 😄); ideally you should use either "resolves" or "fixes"

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (9863c2f) to head (d0f2e9b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
+ Coverage   68.49%   68.75%   +0.25%     
==========================================
  Files         183      184       +1     
  Lines       17574    17719     +145     
==========================================
+ Hits        12037    12182     +145     
  Misses       4877     4877              
  Partials      660      660

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hogo6002 hogo6002 merged commit 581d1a3 into google:main Nov 8, 2024
13 checks passed
@michaelkedar michaelkedar mentioned this pull request Nov 12, 2024
Merged
michaelkedar added a commit that referenced this pull request Nov 12, 2024
@michaelkedar
fix: add "slices" import back in (#1395)
9a303ec 
#1329 removed the slices import in `vulnerability_result.go`, because it
was no longer using it.
At the same time, #1385 added a new usage of the module.

Add the import back to make osv-scanner build again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

@oliverchang oliverchang oliverchang approved these changes

@another-rex another-rex Awaiting requested review from another-rex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Displaying unimportant vulnerabilities in HTML reports
4 participants
@hogo6002 @G-Rath @codecov-commenter @oliverchang