-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add versions fixture generator for Red Hat #1356
base: main
Are you sure you want to change the base?
Conversation
b6e974a
to
44a250c
Compare
nice, that's a very reasonable "worst case with no cache" time given the size (as a reminder, Debian is also pretty big typically taking 5+ minutes, but with caching it only takes ~20 seconds 😄)
double nice - way to go caching 🥳 |
5d7f6b8
to
add759d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1356 +/- ##
==========================================
- Coverage 68.96% 68.94% -0.02%
==========================================
Files 185 185
Lines 17934 17934
==========================================
- Hits 12368 12365 -3
- Misses 4903 4905 +2
- Partials 663 664 +1 ☔ View full report in Codecov by Sentry. |
a08e2b8
to
502c632
Compare
502c632
to
b0de981
Compare
b0de981
to
cc321c1
Compare
This adds a
semantic
fixture generator for the Red Hat ecosystem - as this ends up being just under 2mb, I've not committed the file like the others, instead making the test suite only use it if it's actually present.It works by leveraging
rpm
s built-in Lua interpreter, which includes exposing thevercmp
function meaning we can haverpm
tell us what the result of comparing two versions are so long as there's a version of that available.In terms of actually getting a version of
rpm
, that turns out to be a lot harder with Docker I assume just because CentOS & co is a less open-source-y distro vs the others; there are images, but they're all generally very big. In an interesting twist though it turns out Debian actually ships a version ofrpm
for building and the like - it has had it's package management abilities neutered, but that's not something we need so a simpleapt install rpm
gives us the dependency we need.