-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasmi: initial integration #12665
base: master
Are you sure you want to change the base?
wasmi: initial integration #12665
Conversation
Robbepop is integrating a new project: |
a68d92e
to
e9a4301
Compare
e9a4301
to
8d4db71
Compare
It is a bit painful for me not to be able to debug locally. I've been looking into the failed
So we explicitly build for This is also why the following
@vitorguidi do you have any clues why a |
@vitorguidi hi, sorry for the bad state of this PR. I'd really love to have OSS-fuzz support for Wasmi but I cannot see a way to test the scripts locally and cannot seem to reproduce what is happening on CI with what I said in this comment. Do you have any ideas what I could do or try out? |
Thank you for working on this. Our instructions for testing locally are here: https://google.github.io/oss-fuzz/getting-started/new-project-guide/#testing-locally. In this case, it looks like the failure is in the |
@oliverchang Thank you for your reply. Unfortunately I cannot test the But I will try out that particular command and see if that works in isolation. edit: Not working since I cannot even build the - InvalidBaseImagePlatform: Base image gcr.io/oss-fuzz-base/base-builder-rust was pulled with platform "linux/amd64", expected "linux/arm64" for current build (line 17) This is due to the linked issue with Macbook M2 Pro incompatibility. |
This proposes to add the Wasmi project to OSS-fuzz.
Wasmi is an efficient WebAssembly interpreter especially suited for embedded environments similar to Wasm3.
It has over 7M downloads on crates.io, a Rust and C API, and is used as security critical component in several big projects, especially in the blockchain industry. Recently Wasmi has been added as backend by the Wasmer project which is also registered in OSS-fuzz.
2 audits have been conducted for Wasmi so far which (amongst others) concluded that Wasmi ideally should be registered to the OSS-fuzz project if possible.
Unfortunately I could not test the
Dockerfile
and shell script locally due to this issue: #10967(I am open to suggestions on how to fix the local test setup.)
This adds the 3 fuzzing targets provided by the Wasmi project,
translate
,execute
anddifferential
.The setup is very simple since it mostly uses the recommended
cargo-fuzz
.