Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize dut_id for use in output file name #941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdve
Copy link
Contributor

@jdve jdve commented Aug 19, 2020

Sometimes the DUT id may contain characters that aren't appropriate for
file names. Sanitize the dut_id, so that we can safely use any ID.


This change is Reviewable

@google-cla
Copy link

google-cla bot commented Aug 19, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jdve
Copy link
Contributor Author

jdve commented Aug 25, 2020

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Aug 25, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jdve
Copy link
Contributor Author

jdve commented Aug 27, 2020

@googlebot I signed it!

Sometimes the DUT id may contain characters that aren't appropriate for
file names. Sanitize the dut_id, so that we can safely use any ID.
@jdve jdve force-pushed the sanitize-dut-id branch from e0f6f0f to cb5bfc3 Compare August 27, 2020 18:29
@nbai2022 nbai2022 self-requested a review September 28, 2022 16:39
Comment on lines +131 to +134
def _get_valid_filename(s):
# Reference: https://stackoverflow.com/a/46801075
s = str(s).strip().replace(' ', '_')
return re.sub(r'(?u)[^-\w.]', '_', s)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've hit an issue before where the filename was too long for the filesystem, this could be guarded against too here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants