If run_if throws exception (not intentionally), test will terminate with pass outcome #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glados-verma
requested changes
Dec 11, 2024
openhtf/core/phase_executor.py
Outdated
| @@ -307,8 +307,10 @@ def _execute_phase_once( | |||
| try: | |||
| run_phase = phase_desc.options.run_if() | |||
| except Exception: # pylint: disable=broad-except | |||
| self.logger.debug('Phase %s stopped due to a fault in run_if function.', | |||
| phase_desc.name) | |||
There was a problem hiding this comment.
Please line up the start of this line with the opening parenthesis on the previous line. Make sure you're using spaces and not tabs to do the alignment.
glados-verma
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details are provided inside issue
This change is