Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Integration: python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] #1185

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 1, 2024

Test on current versions of Python.


This change is Reviewable

@glados-verma
Copy link
Collaborator

glados-verma commented Nov 4, 2024

A little bit of work is need to support 3.12 and newer - I made partial progress. I think the only thing still needing work is making the built-in test profiling work correctly - for some reason the generated profile files seem to be empty.

@glados-verma
Copy link
Collaborator

      profile_tempfile = tempfile.NamedTemporaryFile(delete=False)

The new optional parameter in Python 3.12 is called delete_on_close which is different than delete.

Yes, but: If delete is false, the value of delete_on_close is ignored from NamedTemporaryFile

@cclauss cclauss changed the title Continuous Integration: python-version: ["3.9", "3.11", "3.13"] Continuous Integration: python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] Nov 7, 2024
@cclauss cclauss requested a review from glados-verma November 8, 2024 19:31
@glados-verma
Copy link
Collaborator

I'm looking into the profiling breakage under Python3.12+. The error message might be misleading.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 12, 2024

@glados-verma
Copy link
Collaborator

The distutils related issue is already fixed in #1183 . The problem right now is that the profiling unit test fails. I have found the cause for the breakage. It looks like the profiling implementation in OpenHTF isn't quite right, so I'm looking into that now.

@glados-verma
Copy link
Collaborator

#1194 fixes the profiling issue

.github/workflows/continuous_integration.yml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@glados-verma
Copy link
Collaborator

Thanks for the PR!

@glados-verma glados-verma merged commit a6bf9e1 into google:master Nov 12, 2024
8 checks passed
@cclauss cclauss deleted the patch-2 branch November 12, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants