Remove sockJS and use websocket for the front-end. #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This attempts to remove both tornado-sockjs from the HTF servers and sockJS from the front-end getting served. SockJS is a websocket emulator used as a compatibility shim in environments that don't support the websocket API. However, the TornadoSockJS library is no longer being maintained. PiperOrigin-RevId: 647392280
copybara-service
bot
force-pushed
the
test_647392280
branch
from
196dc63 to
c49a198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove sockJS and use websocket for the front-end.
This attempts to remove both tornado-sockjs from the HTF servers and sockJS from the front-end getting served.
SockJS is a websocket emulator used as a compatibility shim in environments that don't support the websocket API. However, the TornadoSockJS library is no longer being maintained.
This change is