fixed typos and closed open brackets (#807) #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update mfg_event.proto fixed typos and closed open brackets (google#807) fixed typos and closed open brackets (google#807)
dbhatman
reviewed
Dec 14, 2023
| the _converter callable attribute only occurs once and the resulting protobuf | ||
| is cached in memory on the instance. | ||
|
|
||
| The upload callback will upload to mfg-inspector.com using the given | ||
| username and authentication key (which should be the key data itself, not a | ||
| filename or file). | ||
|
|
||
| In typical productin setups, we *first* save the protobuf to disk then attempt | ||
| In typical production setups, we *first* save the protobuf to disk then attempt |
There was a problem hiding this comment.
Would you mind tweaking this to get every line to fix into 80 characters?
There was a problem hiding this comment.
Would you review the change I made addressing to the comment?
There was a problem hiding this comment.
Ah sorry I should have been more clear. Lets move 1 word down one line at a time here. Basically what I mean is change this paragraph to be:
In typical production setups, we *first* save the protobuf to disk then
attempt to upload the protobuf to mfg-inspector. In the event of a network,
outage the result of the test run is available on disk and a separate process
can retry the upload when the network is available.
There was a problem hiding this comment.
Thank You I changed it as desired
addressed the comment "80 character/line"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is