Python3.10 compatibility #1093
Closed
Python3.10 compatibility #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this go well with this sockjs removal PR? I would also like to use a newer version of python. If only to get switch-case in python 3.10. |
|
Should no longer be needed after #1181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run WebUI in Python3.10, I get an error
AttributeError: module 'collections' has no attribute 'MutableMapping'. It happens becausecollections.MutableMappinggot moved tocollections.abc.MutableMappingin Python3.10.Ideally, I'd have to bump tornado package, but I haven't had any success doing so because of the new async policies, that tornado>=5 started following. I could not make async loop to run correctly and even if I did, I'd not be sure that something else has not broken, hence this PR.
This change is