Fix web_gui build #1035
Merged
Fix web_gui build #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalten
force-pushed
the
laurenz/fix-missing-safehtml-type
branch
from
505b7f9 to
1d3f406
Compare
|
@glados-verma @dbhatman would be happy to get your eyes on this. |
glados-verma
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Thanks for your excellent work @lalten !
Note for any future readers - we still need to downgrade the Node version (e.g. via the n command) to v9 in order to build this (PR #1024 might help us use newer Node versions). Additionally the instructions in CONTRIBUTDING.md are outdated; check the README.md in the web_gui directory (I'll fix the docs in a separate PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web interface is currently broken on master and won't build.
This PR:
SafeHtmltypeFixes #1039
This change is