Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large dictionary files, the documentation recommends simply using
mmap
to open them. This works, however as internally open-vcdiff always copies this data into theVCDiffEngine
immediately, the full file has to be present in memory, without being able to take advantage of the kernel's smart caching. This can easily lead to OOM for large files.The change here is fairly minor, essentially it just allows to explicitly specify that the data does not need to be copied and to assume that its lifetime is sufficient.