vcdecoder: add memory-based output interface #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
VCDiffStreamingDecoder
class expects applications to call into::StartDecoding()
with a dictionary, and then maintains an internal buffer (decoded_target_
) to accumulate pending output bytes. These are then written through::AppendNewOutputText()
and::FlushDecodedTarget()
.The problem with this implementation is that the allocation of this intermediate buffer may fail, which will then result in the application abort with a trap.
This patch adds an alternative interface that does not lead to internal allocation.
StartDecoding()
may now optionally be called with an output buffer and a maximum length, andDecodeChunk()
may be called without anOutputString
parameter. If operated this way, the decoder will directly write to the provided memory buffer, which can, for instance, bemmap()
ed on a block device.The old interface is kept around for full compatibility.
This should address #12.