Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enums to some logs #1979

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Add enums to some logs #1979

merged 2 commits into from
Mar 13, 2024

Conversation

robertwu1
Copy link
Collaborator

Fixes #1975

@robertwu1 robertwu1 requested a review from philburk March 12, 2024 18:16
philburk
philburk requested changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this. About half of these we actually want the integer value.

src/aaudio/AudioStreamAAudio.cpp Outdated Show resolved Hide resolved
src/common/DataConversionFlowGraph.cpp Outdated Show resolved Hide resolved
src/common/DataConversionFlowGraph.cpp Outdated Show resolved Hide resolved
src/common/DataConversionFlowGraph.cpp Outdated Show resolved Hide resolved
@robertwu1 robertwu1 merged commit 70ef948 into main Mar 13, 2024
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/enumstologs branch March 13, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler warnings when building Oboe for CTS Verifier
2 participants
@robertwu1 @philburk