Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible memory leak #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klebertarcisio
Copy link

@klebertarcisio klebertarcisio commented Aug 18, 2020

Hi everyone,

I would like to know where this data is deallocated.

neper/histo.c

Lines 457 to 474 in 2dd28d3

struct neper_histo_factory *neper_histo_factory(const struct thread *t,
int num_buckets, double growth)
{
struct histo_factory_impl *impl =
calloc(1, sizeof(struct histo_factory_impl));
struct neper_histo_factory *factory = &impl->factory;
factory->create = neper_histo_factory_create;
factory->fini = neper_histo_factory_fini;
impl->thread = t;
impl->num_buckets = num_buckets;
impl->ceil = calloc(impl->num_buckets, sizeof(int));
histo_hash(num_buckets, growth, impl->ceil);
return factory;
}

This pull request tries to fix a possible memory leak.

Regards

possible memory leak
@google-cla
Copy link

google-cla bot commented Aug 18, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant