Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new lit component <extra-model> which will console.log a message when it's being added to <model-viewer> #4904

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

samaneh-kazemi
Copy link
Collaborator

Reference Issue

import {ContextLostEvent, Renderer} from './three-components/Renderer.js';
import {clamp, debounce} from './utilities.js';
import {ProgressTracker} from './utilities/progress-tracker.js';
import { ReactiveElement } from 'lit';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your formatter isn't set up to use our .clang-format style. Can you fix that to clean up this diff?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to do it manually, somehow vscode doesn't pick that for me:
./node_modules/.bin/clang-format -i packages/model-viewer/src/model-viewer-base.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants